Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about adding rcParams argument in ModelCardGenerator #263

Open
jeongukjae opened this issue Jul 31, 2023 · 2 comments
Open

How about adding rcParams argument in ModelCardGenerator #263

jeongukjae opened this issue Jul 31, 2023 · 2 comments

Comments

@jeongukjae
Copy link
Contributor

For non-English projects, it is essential to change the font configs to render graphics properly.
If cannot, the graphics in the model card looks as follows:

test

So, it could be great if ModelCardGenerator can accept the argument like 'matplotlib_rcparams'.

mc_gen = ModelCardGenerator(
  pushed_model=...,
  ...
  ...
  matplotlib_rcparams=json.dumps({
    "font.family": "NanumGothic",
    ...
  }),
)

mentioning code owners of ModelCardGenerator @codesue @hanneshapke

@codesue
Copy link
Contributor

codesue commented Aug 3, 2023

Great idea! In addition to supporting other languages, it would be nice to be able to customize the plots.

@jeongukjae
Copy link
Contributor Author

@codesue Oh, it would be great if that's possible.
I think that is another topic, so I'm leaving that at tensorflow/model-card-toolkit#296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants