Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align pylintrc with the one used by TFX #64

Open
TheMichaelHu opened this issue Aug 9, 2021 · 2 comments
Open

Align pylintrc with the one used by TFX #64

TheMichaelHu opened this issue Aug 9, 2021 · 2 comments
Assignees
@TheMichaelHu

Comments

@TheMichaelHu
Copy link
Contributor

In #63 we needed to modify the original pylintrc to ignore super-with-arguments in order to get the sklearn examples to pass pre-commit checks.

Fix the linter errors in the sklearn example and remove the change that was added to pylint configs.
@TheMichaelHu TheMichaelHu self-assigned this Aug 9, 2021
@rcrowe-google
Copy link
Collaborator

@casassg FYI for comment

@casassg
Copy link
Member

casassg commented Aug 13, 2021

yup. We talked about this in #63

That said, super-with-arguments is not a terrible thing to have either, so I would be fine by keeping it (actually TFX does use some of those as well it seems)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheMichaelHu TheMichaelHu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheMichaelHu @casassg @rcrowe-google