Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/README.md has dead link to getting started #272

Open
pritamdodeja opened this issue May 18, 2022 · 4 comments
Open

examples/README.md has dead link to getting started #272

pritamdodeja opened this issue May 18, 2022 · 4 comments
Assignees

Comments

@pritamdodeja
Copy link

I have submitted pr269 with a fix to point it to here. It currently points here which gives a 404.

@pindinagesh
Copy link

Hi @pritamdodeja

I have assigned a reviewer to your PR, Could you please send the source page link where you got 404 error link will look into it. Thanks!

@pritamdodeja
Copy link
Author

pritamdodeja commented May 23, 2022

Thanks @pindinagesh It's at https://github.com/tensorflow/transform/blob/master/examples/README.md in the Census Income Example section. It says 'Get started with TensorFlow Transform', and points to a dead location.

@pindinagesh
Copy link

Hi @pritamdodeja

I went through the link which you provided for a broken link that was appropriate, the issue will be closed once it gets merged. Thanks!

@pritamdodeja
Copy link
Author

Thanks @pindinagesh! In a conversation with zoyahav on this, I mentioned the following:

what do you think about featuring the getting started notebook more prominently off of https://github.com/tensorflow/transform/blob/master/README.md itself, and making it a relative reference so that anybody that clones the repo can try it out locally?

It's a great starter notebook but it's pretty hidden. If it was made a relative reference, anybody can clone the repo locally and directly run it in jupyter lab from README.md.

Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants