Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning script shortcut as swipe action of existing nova launcher shortcut does not work #84

Open
macerg opened this issue Jul 18, 2022 · 14 comments

Comments

@macerg
Copy link

macerg commented Jul 18, 2022

Desktop icon up/down swipe function. Cannot assign to an action. Was ok 0.12. broken in 0.13.0

@macerg macerg changed the title Nova launcher prime issues Nova Launcher Prime issues Jul 18, 2022
@agnostic-apollo
Copy link
Member

Working fine if you install both Nova Launcher and Nova Launcher Prime app. And swipe up/down actions are controlled by launcher, not Termux:Widget anyways.

@agnostic-apollo agnostic-apollo closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2022
@macerg
Copy link
Author

macerg commented Jul 18, 2022

I know that, you try and set up a new action, the setup dialogue is screwed up. I have Nova launcher and prime installed. Worked fine for years until this update.

@macerg
Copy link
Author

macerg commented Jul 18, 2022 via email

@agnostic-apollo
Copy link
Member

Post video/screenshot. I already tested with latest nova on Android 11 and swipe setting from long hold icon -> edit works. Make sure you recreated all shortcuts again after updating as per changelog.

https://github.com/termux/termux-widget/releases

@macerg
Copy link
Author

macerg commented Jul 19, 2022

It won't let me recreate my actions as dialogue is screwed. I'll leave that here as I've regressed to 0.12. and all is working. I'm very confident that someone else will come across this issue and it will be fixed. Just a matter of time. Here's what I did. Created a new shortcut for a . shortcuts/task. Worked fine, now assign a 'swipe up' task to that shortcut. Dialogue takes you through creating a new shortcut & doesn't assign it to the 'swipe up' action of the previous shortcut. Bye, that's all from me.

@agnostic-apollo
Copy link
Member

agnostic-apollo commented Jul 19, 2022

You mean assign another termux script shortcut to swipe actions of existing shortcut, you should have been more clear. Anyways, that won't work currently, since v0.13.0 due to security reasons when shortcut creation is initiated, then termux-widget sends a pinned shortcut to default launcher app on Android >= 8 and does not send back static shortcut, which is what nova expects back. Considering that this could be a security risk, since launcher will then be able to execute any scripts under allowed shortcut directories, I will have to think on whether to somehow allow this, like with a prompt.

@agnostic-apollo agnostic-apollo changed the title Nova Launcher Prime issues Assigning script shortcut as swipe action of existing nova launcher shortcut does not work Jul 19, 2022
@macerg
Copy link
Author

macerg commented Jul 19, 2022

Ok, thanks. I should have been more clear. Thanks for reopening and recognising issue.

@macerg
Copy link
Author

macerg commented Jul 19, 2022

Don't understand why this doesn't seem to be a "security issue" in 0.12 and earlier.

@macerg
Copy link
Author

macerg commented Jul 19, 2022 via email

@macerg
Copy link
Author

macerg commented Oct 11, 2022 via email

@L-Cool-J
Copy link

Same issues here, and not only Nova Launcher. Instead of assigning to an action, it(v0.13) just creates a new shortcut icon on Home screen. v0.12 works fine.

@macerg
Copy link
Author

macerg commented Nov 10, 2022

No signs of being fixed yet then?

@agnostic-apollo
Copy link
Member

It has already been fixed locally, will push changes after termux-app/termux-shared ones are.

@SF73
Copy link

SF73 commented Jan 27, 2023

It has already been fixed locally, will push changes after termux-app/termux-shared ones are.

Any news on when this fix will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants