feat: Allow asset participation in gov #131
Conversation
There was a problem hiding this comment.
Hello @phamminh0811, thanks for submitting the PR! Sorry for the review delay. Overall the PR looks good I left few comments for you to review.
One more comment, regarding the routes for governance are not working, can you double check that please?
allianced tx gov submit-legacy-proposal create-alliance ulunax 0.5 0 0.00005 1s --from=alice
Feel free to review the comments. I'll be subscribed to the PR so I can improve the reviewing times. Thanks again!
| return keeper | ||
| } | ||
|
|
||
| func (k *Keeper) RegisterKeepers(ak alliancekeeper.Keeper, bk custombankkeeper.Keeper, sk stakingkeeper.Keeper) { |
There was a problem hiding this comment.
Seems like the custom keepers are never registered in the app.go. Should be a similar case to the custom bank keeper (https://github.com/terra-money/alliance/blob/main/app/app.go#L431)
| package types | ||
|
|
||
| import sdk "github.com/cosmos/cosmos-sdk/types" | ||
|
|
||
| type StakingKeeper interface { | ||
| BondDenom(ctx sdk.Context) (res string) | ||
| } |
There was a problem hiding this comment.
Seems like the keeper interface is not being used because you're using the default CosmosSDK keeper. Should it be deleted?
Closes: #50
What is the purpose of the change