-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ExternalStudioHost
be its own resource
#2
Comments
My initial concern with extracting ExternalStudioHost into its own resource is that there can only be one external studio host per project. Creating multiple instances would interfere with each other. However, this is exactly how the I think it is reasonably to think that people with the use case described in the original write-up will be aware if there are more than one ExternalStudioHost resource is created (or at least, they will figure out out really quickly). |
I was also concerned that the change here would not be backwards compatible, and it was not clear to me how many people would be affected. However, in doing some initial research, I have found a bug in the underlying While the proposed change will technically break backwards compatibility, it won't in practice. |
Here is a short example of what I think the API should look like.
Does this make sense to you, @petero-dk? |
I think that looks excellent, just to make sure that would work with a data project object also? |
Yes, good call out, thanks. I will use this to start going through your PR later this evening. |
The following is from @petero-dk in #1.
Why would I want this:
The same sanity project is used in a couple of different deployment pipelines (think staging / prod / dev) and for the Sanity project only one would be able to have the resource of the project (which i don't want) so I have linked the Sanity project as a data object in terraform.
However for my production pipeline, I would like to set the external host name as that is dependent on other resources in that pipeline.
Currently that is not possible because it is available only on the project resource.
The text was updated successfully, but these errors were encountered: