Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages (41) #383

Open
HolQue opened this issue Nov 6, 2024 · 4 comments
Open

Error messages (41) #383

HolQue opened this issue Nov 6, 2024 · 4 comments

Comments

@HolQue
Copy link
Collaborator

HolQue commented Nov 6, 2024

The [import] tag requires a string (that is interpreted as file). Therefore the value type must be checked. This is not implemented and the current error handling is insufficient.

Examples:

"[import]" : 123
Error: 'argument of type 'int' is not iterable
"[import]" : [1,2,3]
Error: ''list' object has no attribute 'strip'
"[import]" : {"A" : 1, "B" : 2}
Error: ''dict' object has no attribute 'strip'
"values" : {"A" : 1, "B" : 2},
"[import]" : ${values}['A']
Error: 'File '%values%['A']' is not existing!'!

Expected error handling:

  1. Check value type, error if not a string
  2. Check existence of file, error if file does not exist
  3. Check file content, error in case of content related error
@test-fullautomation
Copy link
Owner

Hi Holger,
please provide tests for this.
Thank you,
Thomas

@HolQue
Copy link
Collaborator Author

HolQue commented Nov 6, 2024

JPP_1161
JPP_1162
JPP_1163
JPP_1164

@namsonx
Copy link
Collaborator

namsonx commented Nov 15, 2024

Hello Holger,

This ticket was solved on stabi branch, could you please help us check again.

Thank you,
Son

@HolQue
Copy link
Collaborator Author

HolQue commented Nov 15, 2024

Current error:

'The value of [import] parameter must be 'str' but receiving the value '123''

Please rephrase to:

The [import] key requires a value of type 'str', but the type is 'int'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants