Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffs/scheduler: deal finality considering deal start epoch #657

Open
jsign opened this issue Oct 5, 2020 · 0 comments
Open

ffs/scheduler: deal finality considering deal start epoch #657

jsign opened this issue Oct 5, 2020 · 0 comments

Comments

@jsign
Copy link
Contributor

jsign commented Oct 5, 2020

Currently, if a deal doesn't report a new status after --dealsfinalitytimeout, it will be considered failed. For example, if a deal is reported Sealing for more than 3 days without any status update, then most probably something bad happened and we should abort watching this deal.

This has some problems:

  • If Powergate is restarted, the timeout will start from zero again. So not entirely ideal.
  • Even if we take as a starting point the time the Job or Deal was created (which would be a good improvement), this doesn't account the fact that the Lotus node could be lagged in the syncing process and not be reporting the latest real status; which ultimately is a problem.

Looks to me the best solution is consider as the finality timeout the StartDealEpoch that was set when the deal was created. This is a hard-limit for the miner to publish the deal on-chain. If the miner fails to do that in time, the network would reject the deal. So looks like this should be the best way to solve this timeout challenge.

Doing it this way will work correctly if the Lotus node has fall behind, since we're using a timing relative to network age, and not absolute time. If for some reason Lotus takes a bunch of time to sync, the timeout will wait accordingly too.

@jsign jsign changed the title ffs/scheduler: deal finality relative to startepoch ffs/scheduler: deal finality considering deal start epoch Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant