Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index/ask: use arbitrary precision for prices #776

Open
jsign opened this issue Feb 19, 2021 · 0 comments
Open

index/ask: use arbitrary precision for prices #776

jsign opened this issue Feb 19, 2021 · 0 comments

Comments

@jsign
Copy link
Contributor

jsign commented Feb 19, 2021

We're relying on unsigned integer for prices which is fine (realistically), but on border-case scenarios could overflow.
We should store prices in big.Int byte representation, or simple strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsign