Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Return objects in switch cases #8

Open
nealfennimore opened this issue Mar 23, 2018 · 0 comments
Open

Refactor: Return objects in switch cases #8

nealfennimore opened this issue Mar 23, 2018 · 0 comments
Assignees
@lucatume @nealfennimore

Comments

@nealfennimore
Copy link
Contributor

We can just return the objects here, rather than using break. As long the object returned is new and not mutating the current state, there shouldn't be any warnings from redux

https://github.com/moderntribe/rest-api-tester/blob/cd397c8a34c86f5edcf752f3cd8ce090f12fa5bb/src/resources/js/src/reducers/response.js#L7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucatume lucatume

@nealfennimore nealfennimore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sc0ttkclark @lucatume @nealfennimore