Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spend time refactoring variable names, types etc #90

Open
8 tasks
theophanemayaud opened this issue Oct 16, 2022 · 0 comments
Open
8 tasks

Spend time refactoring variable names, types etc #90

theophanemayaud opened this issue Oct 16, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@theophanemayaud
Copy link
Owner

theophanemayaud commented Oct 16, 2022

  • Use constants instead of magic strings like in mainwindow.cpp _ui->findDuplicates->text() == "Stop"
  • Make functions constants if they do not use state
  • Check imports if really necessary and also which ones might be mission
  • Investigate not used warnings
  • Refactor functions and interactions to make overall program more simple
  • Investigate static Db implementation where the Db location is store in static variable and no object created every time for Db access
  • in mainwindow.cpp investigate the _everyVideo video pathnames list uses to see if it could be made more efficient, for example while adding videos to list checking for duplicates for(const auto &alreadyAddedFile : _everyVideo) is a for loop each time, not very efficient !
  • Find TODO-REFACTOR comments in code for places that might be good to look at
@theophanemayaud theophanemayaud added the enhancement New feature or request label Oct 16, 2022
@theophanemayaud theophanemayaud added this to the High priority milestone Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant