Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download/Dump buttons are disabled/dimmed after downloading #8

Open
acquaalta opened this issue Nov 29, 2019 · 2 comments
Open

Download/Dump buttons are disabled/dimmed after downloading #8

acquaalta opened this issue Nov 29, 2019 · 2 comments

Comments

@acquaalta
Copy link

Hi,
Plugin version: 1.2.6

After downloading/dumping the files in the "Download" screen of the plugin, the buttons are getting disabled/dimmed and the user can't use them again.

ASR - Download buttons are disabled

I'm not sure if this is a bug or actually a feature.
On the one hand it's not ideal UX-wise to prevent the user to use the buttons in the screen. The user should at least be able to use the "Cancel" button so he/she could navigate to the previous screen without using the "Back" button of the browser.
On the other hand, the buttons getting disabled/dimmed signal to the user that the file has already been downloaded and there isn't much value to clicking the "Dump files" button again right away.

In any case, it seems that refreshing the page in the browser brings back the buttons to to an "Enabled" mode.

In any case, thanks for the great plugin :-)

P.S.: Maybe the "Dump files" button text should be updated to "Download files" or just "Download", so it would match the "Download" terminology of the "Download" screen.

@thepurpleblob
Copy link
Owner

I was unable to reproduce this. I could press either button multiple times.

@acquaalta
Copy link
Author

I had the chance to repro this issue on Moodle 3.8 with the Boost theme active, on different browsers and on different computers (corporate network, private computers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants