Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tag version (for CocoaPods) #44

Open
bachand opened this issue Jan 23, 2013 · 3 comments
Open

New tag version (for CocoaPods) #44

bachand opened this issue Jan 23, 2013 · 3 comments
Assignees

Comments

@bachand
Copy link

bachand commented Jan 23, 2013

The current version of TITokenField on CocoaPods is from six months ago. Even if TITokenField isn't ready for a 1.0 release, it would be great to have some of the more recent changes available through CocoaPods. It seems like this would entail making a new tag as well as creating an updated spec here. That being said, simply making a new tag would be sufficient since that would enable someone else to update the spec.

@ghost ghost assigned thermogl Jan 23, 2013
@zxcat
Copy link

zxcat commented Oct 16, 2013

+1 for new tag!
Moving to ARC makes spec outdated. So pod 'TITokenField', :head don't work now. It's needed to change build settings for TITokenField to enable ARC. After every pod update. It's quite annoying

@thermogl
Copy link
Owner

I can't for the life of me remember how to update the tag. Could one of you point me in the right direction? :)

@RaviDesai
Copy link

I too could really use some features sitting in 'master' right now (tokenField:shouldUseCustomSearchForSearchString and tokenField:performCustomSearchForSearchString:withCompletionHandler), and need a new tag (0.9.5.1?) so I can reference it from a dependency in a pod spec. If you are willing @thermogl, but you are still struggling to tag the latest in master, the commands usually are:

git tag -a 0.9.5.1 -m "version 0.9.5.1"
git push --tags

But you run your pod specs a little differently than I typically do, so that may not be all you need to do. In addition, it would be nice if those two methods (tokenField:shouldUseCustomSearchForSearchString and tokenField:performCustomSearchForSearchString:withCompletionHandler) showed up in the TITokenFieldDelegate protocol. It would make accessing them from Swift a little nicer.

If you are not ready to tag 0.9.5.1 from master, is there a way I could retro-fit the existing resultsForSearchString method in the currently tagged 0.9.5 without cloning your repo somewhere local?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants