We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spender
Current implementation of ERC20WithPermit uses the term spender to refer to the source account from which tokens are transferred from, while both the EIP (see https://eips.ethereum.org/EIPS/eip-20) and major implementations (like e.g. OpenZeppelin, https://github.com/OpenZeppelin/openzeppelin-contracts/blob/a55b7d13722e7ce850b626da2313f3e66ca1d101/contracts/token/ERC20/ERC20.sol#L163) use the same term to refer to an account that's been authorized to spend tokens on behalf of another. This can lead to confusion (it almost happened to me recently preparing a DAO proposal), and has an ABI-compatible fix.
ERC20WithPermit
The text was updated successfully, but these errors were encountered:
Make proper use of the term spender...
ab8ecd3
... in ERC20WithPermit. Closes #15
@cygnusv if you have a minute I'd love a spot check!
#18
Sorry, something went wrong.
f8301fa
Successfully merging a pull request may close this issue.
Current implementation of
ERC20WithPermit
uses the termspender
to refer to the source account from which tokens are transferred from, while both the EIP (see https://eips.ethereum.org/EIPS/eip-20) and major implementations (like e.g. OpenZeppelin, https://github.com/OpenZeppelin/openzeppelin-contracts/blob/a55b7d13722e7ce850b626da2313f3e66ca1d101/contracts/token/ERC20/ERC20.sol#L163) use the same term to refer to an account that's been authorized to spend tokens on behalf of another. This can lead to confusion (it almost happened to me recently preparing a DAO proposal), and has an ABI-compatible fix.The text was updated successfully, but these errors were encountered: