Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reminder jobs to save username separate from message #138

Open
kb0rg opened this issue Oct 3, 2019 · 0 comments
Open

Update reminder jobs to save username separate from message #138

kb0rg opened this issue Oct 3, 2019 · 0 comments

Comments

@kb0rg
Copy link
Contributor

kb0rg commented Oct 3, 2019

Currently, when a user calls \remind team [...] or remind me [...], the relevant at-mentions are constructed and saved as part of the reminder's message.

The becomes a problem if the user chooses to update their message: the at-mention is not automatically preserved; the new message input will overwrite it.

We should save the username as a separate field on the job, and reconstruct the at-mention when a message is formatted for display and/or triggered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kb0rg