-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Known limitations? #22
Comments
Is there any consistency in the ones that are being skipped (eg they have query params, or they are routes you've defined?). You could get the manifest for those urls and see if your global is tagged in them - |
No, I can't find any consistency unfortunately. I have 2 simple pages: /privacy-statement They are both cached, both have a HTML file. When I look up /fietsen, I get a ton tags:
|
So, when I update the privacy statement in Statamic, it clears the cache for both the privacy statement page and the "fietsen" page. Then, I go to /fietsen and /privacy-statement. Ater that, I run the cache lookup code you send and then I find results for both. Is there a way that the static:warm create the HTML file for privacy-statement, but it doesn't add the tags in the cache? |
Had you cleared your static cache after you installed this add on? |
Yes, I did. I cleared everything and have re-run the cache. |
Odd then. When you warm the cache are you allowing concurrent requests? |
I don't know. How can I check? I'm testing locally. Another update; I have update the entry privacy statement from the cp to see what it does. Now, when I redo the caching, it does get it's tags connected to it. Seems like doing a save one time helped. I still have this problem with other URL's though. Does it perhaps have something to do with a modified timestamp or something? Where or when is the cache->add() being triggered? Maybe I can find something there? |
When you are running the warm command are you passing anything to it to have concurrency or are you running it on a queue?
I think the issue is coming from you warming it - oddly I'm not able to recreate that issue - when I warm I do get all the tags added. The tagging is done through middleware: statamic-cache-tracker/src/Http/Middleware/CacheTracker.php Lines 79 to 81 in cdcb43d
|
No, I simply use the terminal: Thanks for pointing out, I'll see if I can find something. Like I said before, the weird thing is that after saving the privacy statement once, It is getting picked up. There are pages that have been added from a migration script. Maybe there could be missing something there? That has been 2 months ago though and the pages are working when navigating to it, they might have never been saved in the CP itself. Just a thought. |
Possibly - that’s hard to know but it seems unlikely. As long as the url can be hit it should be tracked. |
Hi,
I'm testing with using the addon in combination with the full cache. I can see it works great for the most part. I have about 2200 HTML files.
However, I'm using a global title for the <title></title> on every page. When I change this title, it clears about 95% of the pages. Any idea why it's skipping the rest of them? Any idea where to look for?
The text was updated successfully, but these errors were encountered: