-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customisable highlight style? #1191
Comments
(btw i can try and make a PR for this, just asking to be sure that this feature fits into the project plans) |
I think we still need a style attribute to be able to set any color, which isn't possible by a class: https://strudel.cc/#cygiYmQqPDEgMj4gLSwgaGgoMTAsMTYpLC0gcmltIikuYmFuaygnQ2FzaW9SWjEnKQouY29sb3IoIltjeWFuIHwgbWFnZW50YSB8wqB5ZWxsb3ddKjgiKQouX3BpYW5vcm9sbCgp |
Oh I see -- this is a tricky one. I'd really love to try out different styles for the highlights, e.g. with CSS transitions, so I'll keep thinking of a possible approach that doesn't break the Right now I'm thinking that adding a class (e.g. I'll try to find some time during the weekend to set up a dev environment and test this out, but I'd definitely welcome any caveats you see with this approach. Thank you for the quick reaction! I'm porting my work from Tidal to Strudel mostly because of the highlight feature, so I'm really eager to help make things even better. |
I actually got this going -- adding the Now wondering if it makes sense to have a user-facing function to alter the highlight style. I'll read up on how Strudel does things like |
One thought: perhaps Strudel could have a |
I really like this idea, could be finessed later but would make a lot of things possible right now |
good idea! the rule could be: if |
it should be noted that |
That makes sense, and I can perfectly live with that limitation :-) |
This is great and exciting! I suppose we could also call |
you could use |
now implemented in #1202 (soon to be deployed) |
Currently, the highlight style is somewhat hardcoded here.
Instead of setting a
style
attribute, would it be feasible to set a class instead, so that it can be changed through CSS?Ideally this could be then redefined by the user through a function, but just having it as a class would enable me to change things with a userscript and try out other highlighting styles.
The text was updated successfully, but these errors were encountered: