Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review TPCH runs #284

Open
krlmlr opened this issue Oct 19, 2024 · 1 comment
Open

Review TPCH runs #284

krlmlr opened this issue Oct 19, 2024 · 1 comment
Milestone
1.0.0

Comments

@krlmlr
Copy link
Member

krlmlr commented Oct 19, 2024

Query 10 didn't finish on my machine for sf=1. I suspect this is due to our use of the "full compatibility" operators from the rfuns extension for comparison. We might want to use faster variants in "good" cases (e.g., compare a column with a constant) so that duckdb can optimize.

Related: #270, CC @toppyy.
@krlmlr
Copy link
Member Author

krlmlr commented Nov 3, 2024

All good now, this was due to undesired materialization, #289.

@krlmlr krlmlr closed this as completed Nov 3, 2024
@krlmlr krlmlr added this to the 1.0.0 milestone Nov 3, 2024
@krlmlr krlmlr mentioned this issue Nov 3, 2024
Draft
@krlmlr krlmlr reopened this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@krlmlr