From b755b9d680e26046557dc67ead6e04284bad1017 Mon Sep 17 00:00:00 2001 From: Max SCHMELLER Date: Tue, 1 Oct 2024 18:45:23 +0900 Subject: [PATCH 1/4] docs: remove obsolete note about transport drivers Signed-off-by: Max SCHMELLER --- README.md | 6 ------ docs/installation.md | 6 ------ 2 files changed, 12 deletions(-) diff --git a/README.md b/README.md index a41137d4c..5cb122653 100644 --- a/README.md +++ b/README.md @@ -32,12 +32,6 @@ Nebula builds with ROS 2 Galactic and Humble. > **Note** > > Boost version 1.74.0 or later is required. A manual install may be required in Ubuntu versions earlier than 22.04. -> -> **Note** -> -> A [TCP enabled version of ROS' Transport Driver](https://github.com/mojomex/transport_drivers/tree/mutable-buffer-in-udp-callback) is required to use Nebula. -> It is installed automatically into your workspace using the below commands. However, if you already have ROS transport driver binaries installed, you will have to uninstall them to avoid conflicts (replace `humble` with your ROS distribution): -> `sudo apt remove ros-humble-udp-driver ros-humble-io-context` To build Nebula run the following commands in your workspace: diff --git a/docs/installation.md b/docs/installation.md index 5f006bc35..145ee1df3 100644 --- a/docs/installation.md +++ b/docs/installation.md @@ -10,12 +10,6 @@ Please see the [ROS 2 documentation](https://docs.ros.org/en/humble/index.html) > **Note** > > Boost version 1.74.0 or later is required. A manual install may be required in Ubuntu versions earlier than 22.04. -> -> **Note** -> -> A [TCP enabled version of ROS' Transport Driver](https://github.com/mojomex/transport_drivers/tree/mutable-buffer-in-udp-callback) is required to use Nebula. -> It is installed automatically into your workspace using the below commands. However, if you already have ROS transport driver binaries installed, you will have to uninstall them to avoid conflicts (replace `humble` with your ROS distribution): -> `sudo apt remove ros-humble-udp-driver ros-humble-io-context` To build Nebula run the following commands in your workspace: From 316b95ec6b7e44d2945712bf6a23299b78728b5e Mon Sep 17 00:00:00 2001 From: Max SCHMELLER Date: Tue, 1 Oct 2024 18:45:52 +0900 Subject: [PATCH 2/4] docs: remove recommendation to clone into `src` directory Signed-off-by: Max SCHMELLER --- README.md | 10 +++++----- docs/installation.md | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 5cb122653..b7d7fa4e1 100644 --- a/README.md +++ b/README.md @@ -37,13 +37,13 @@ To build Nebula run the following commands in your workspace: ```bash # In workspace -mkdir src -git clone https://github.com/tier4/nebula.git src +git clone https://github.com/tier4/nebula.git +cd nebula # Import dependencies -vcs import src < src/build_depends.repos -rosdep install --from-paths src --ignore-src -y -r +vcs import < build_depends.repos +rosdep install --from-paths . --ignore-src -y -r # Build Nebula -colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release +colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=1 ``` To launch Nebula as a ROS 2 node with default parameters for your sensor model: diff --git a/docs/installation.md b/docs/installation.md index 145ee1df3..957ab82f2 100644 --- a/docs/installation.md +++ b/docs/installation.md @@ -15,13 +15,13 @@ To build Nebula run the following commands in your workspace: ```bash # In workspace -mkdir src -git clone https://github.com/tier4/nebula.git src +git clone https://github.com/tier4/nebula.git +cd nebula # Import dependencies -vcs import src < src/build_depends.repos -rosdep install --from-paths src --ignore-src -y -r +vcs import < build_depends.repos +rosdep install --from-paths . --ignore-src -y -r # Build Nebula -colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release +colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=1 ``` ## Testing your build From e6b34f3ed3b6ec87a3918c5f0df8e1e8dd66c8c4 Mon Sep 17 00:00:00 2001 From: Max SCHMELLER Date: Tue, 1 Oct 2024 18:46:06 +0900 Subject: [PATCH 3/4] chore: update link to about page Signed-off-by: Max SCHMELLER --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b7d7fa4e1..2d533454c 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ Nebula works with ROS 2 and is the recommended sensor driver for the [Autoware]( We recommend you get started with the [Nebula Documention](https://tier4.github.io/nebula/). Here you will find information about the background of the project, how to install and use with ROS 2, and also how to add new sensors to the Nebula driver. -- [About Nebula](https://tier4.github.io/nebula/about) +- [About Nebula](https://tier4.github.io/nebula) - [Design](https://tier4.github.io/nebula/design) - [Supported Sensors](https://tier4.github.io/nebula/supported_sensors) - [Installation](https://tier4.github.io/nebula/installation) From 17cf4ca1fd7692beb03cd5f1ea25dc7baabb8d20 Mon Sep 17 00:00:00 2001 From: David Wong Date: Tue, 1 Oct 2024 23:32:56 +0900 Subject: [PATCH 4/4] chore: add cmake ignore to meta package Signed-off-by: David Wong --- nebula_sensor_driver/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/nebula_sensor_driver/CMakeLists.txt b/nebula_sensor_driver/CMakeLists.txt index f9a39ac72..fccfa36f4 100644 --- a/nebula_sensor_driver/CMakeLists.txt +++ b/nebula_sensor_driver/CMakeLists.txt @@ -1,5 +1,6 @@ cmake_minimum_required(VERSION 3.14) project(nebula_sensor_driver) +set(ignoreMe "${CMAKE_EXPORT_COMPILE_COMMANDS}") find_package(ament_cmake REQUIRED) ament_package()