From 7fb6e01a33350354c71b0de10d0ee93f29bbb006 Mon Sep 17 00:00:00 2001 From: miyakoshi Date: Tue, 2 Jul 2024 11:00:43 +0900 Subject: [PATCH 1/3] total number of processes becomes None --- ros2caret/verb/record.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ros2caret/verb/record.py b/ros2caret/verb/record.py index 30b087d..7ed68c2 100644 --- a/ros2caret/verb/record.py +++ b/ros2caret/verb/record.py @@ -66,6 +66,8 @@ def subscription_callback(self, msg): if msg.caret_node_name in self._caret_node_names: self._caret_node_names.remove(msg.caret_node_name) + else: + return if self._progress: self._progress.update() From 6e2c0216b1490768abd3d48974625d9382146627 Mon Sep 17 00:00:00 2001 From: miyakoshi Date: Tue, 9 Jul 2024 11:49:46 +0900 Subject: [PATCH 2/3] reflected review results --- ros2caret/verb/record.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ros2caret/verb/record.py b/ros2caret/verb/record.py index 7ed68c2..9baf71d 100644 --- a/ros2caret/verb/record.py +++ b/ros2caret/verb/record.py @@ -67,10 +67,8 @@ def subscription_callback(self, msg): if msg.caret_node_name in self._caret_node_names: self._caret_node_names.remove(msg.caret_node_name) else: - return - - if self._progress: - self._progress.update() + if self._progress: + self._progress.update() if len(self._caret_node_names) == 0: self.stop_progress() From 9b2dd0934a2d88ed3b53549df0ababf6590bd91a Mon Sep 17 00:00:00 2001 From: miyakoshi Date: Tue, 9 Jul 2024 13:34:30 +0900 Subject: [PATCH 3/3] reflected the review results again --- ros2caret/verb/record.py | 1 - 1 file changed, 1 deletion(-) diff --git a/ros2caret/verb/record.py b/ros2caret/verb/record.py index 9baf71d..9e11099 100644 --- a/ros2caret/verb/record.py +++ b/ros2caret/verb/record.py @@ -66,7 +66,6 @@ def subscription_callback(self, msg): if msg.caret_node_name in self._caret_node_names: self._caret_node_names.remove(msg.caret_node_name) - else: if self._progress: self._progress.update()