Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: IT fail after change cargo test to cargo nextest #423

Closed
ben1009 opened this issue Sep 18, 2023 · 2 comments
Closed

test: IT fail after change cargo test to cargo nextest #423

ben1009 opened this issue Sep 18, 2023 · 2 comments

Comments

@ben1009
Copy link
Member

ben1009 commented Sep 18, 2023

IT may have concurrency issue, after change test to nextest, can not passed IT, but rollback to cargo test could pass

------------
     Summary [   5.669s] 3/24 tests run: 0 passed, 3 failed, 38 skipped
        FAIL [   2.422s] tikv-client::failpoint_tests txn_cleanup_2pc_locks
        FAIL [   2.616s] tikv-client::failpoint_tests txn_cleanup_async_commit_locks
        FAIL [   3.246s] tikv-client::failpoint_tests txn_cleanup_locks_batch_size
error: test run failed
make: *** [Makefile:26: integration-test] Error 100
Error: Process completed with exit code 2.
@ben1009 ben1009 changed the title flaky test: IT fail after change cargo test to cargo nextest test: IT fail after change cargo test to cargo nextest Sep 18, 2023
@pingyu
Copy link
Collaborator

pingyu commented Oct 3, 2023

Currently IT cases are running on the same real TiKV cluster. So they would be conflict with each other if running concurrently.

At the beginning of each case, it will clear the TiKV to address the conflicts.

It's not possible to run IT cases concurrently by now. Maybe we can utilize multi-tenancy to isolate the test case in the future.

@ben1009
Copy link
Member Author

ben1009 commented Oct 8, 2023

close for now, since the behaviour is kind of by design

@ben1009 ben1009 closed this as completed Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants