New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: minitrace-macro expansion adds empty {} and <> #141

Closed

taqtiqa-mark opened this issue Apr 27, 2022 · 1 comment

Contributor

taqtiqa-mark commented Apr 27, 2022 •

edited

Loading

Legacy minitrace-macro code converts

fn f() {}

into

fn f<>() {
    let __guard = minitrace::local::LocalSpan::enter_with_local_parent("f");
    {}
}

There are two issues:

The __guard should be inside the block expression - correct?
The superfluous <>

This arose in the course of writing unit tests for issue #113

The text was updated successfully, but these errors were encountered:

taqtiqa-mark mentioned this issue

Proc-macro pipeline (issue #113) #127

Closed

17 tasks

Contributor Author

taqtiqa-mark commented Dec 27, 2023

Voided by PR #127 rejection.

taqtiqa-mark closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment