Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA256 and SHA512 might be failing #12

Open
tilkinsc opened this issue Jun 10, 2022 · 1 comment
Open

SHA256 and SHA512 might be failing #12

tilkinsc opened this issue Jun 10, 2022 · 1 comment
Labels
bug help wanted We got some work that needs doin' test me Please confirm this via testing

Comments

@tilkinsc
Copy link
Owner

I am not sure where the root cause is, but the SHA256 and SHA512 are failing in my tests with the test/main.c* programs.

Isolation necessary.

@tilkinsc
Copy link
Owner Author

tilkinsc commented Jun 12, 2022

I think I have SHA256 and SHA512 working. The problem was rooted based on the generation size. A SHA1 HMAC generates 20 bytes. A SHA256 HMAC or SHA512 HMAC generates 32 bytes. This means the library had some hardcoded logic, and additionally it had logic built directly into it due to expecting these. I have found no implementation that uses SHA256 or SHA512 to bounce my library off of them. Authy, what I used for testing, doesn't support SHA256 or SHA512 and I am chatting with their engineering team because thats just unacceptable. SHA1 hashes have been deprecated and not recommended for use, like MD5.

@tilkinsc tilkinsc added bug test me Please confirm this via testing help wanted We got some work that needs doin' labels Jun 7, 2023
@tilkinsc tilkinsc changed the title SHA256 and SHA512 are failing SHA256 and SHA512 might be failing Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted We got some work that needs doin' test me Please confirm this via testing
Projects
None yet
Development

No branches or pull requests

1 participant