Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop callback support in v2 #160

Open
wesleytodd opened this issue Jun 11, 2019 · 3 comments
Open

Drop callback support in v2 #160

wesleytodd opened this issue Jun 11, 2019 · 3 comments

Comments

@wesleytodd
Copy link
Collaborator

I am starting work on what will hopefully be v2 of this module. One of the breaking changes I was thinking of making is to drop the callback interface for migration up/down functions and other exposed api's. What do people think of this? Acceptable?

The benefits are:

  • reduced code and documentation complexity
  • promote use of async/await which is a better paradigm
  • has full support in active node versions

The cons:

  • Callbacks have a long history, users might expect them
  • The feature exists today, we would probably want to deprecate them in a 1.x release soon if we plan to break it in 2.x

Thanks in advance for your thoughts.

@LinusU
Copy link
Collaborator

LinusU commented Jun 12, 2019

I'm 100% for this 👍

@palmerabollo
Copy link

@wesleytodd I'd be happy to try the v2, even if it is still "beta". Is it available somewhere? Thank you.

@wesleytodd
Copy link
Collaborator Author

Hey @palmerabollo, I never finished it :(

While I have a bunch of work in https://github.com/migratejs I don't think it got back to a working state. I do have some projects at work where I plan to use it, and thus finish that but I am not quite there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants