Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cachetools.keys.typedmethodkey? #296

Closed
kuraga opened this issue Feb 16, 2024 · 3 comments
Closed

cachetools.keys.typedmethodkey? #296

kuraga opened this issue Feb 16, 2024 · 3 comments
Assignees
@tkem
Labels
enhancement

Comments

@kuraga
Copy link
Contributor

kuraga commented Feb 16, 2024

There are:

  • cachetools.keys.hashkey,
  • cachetools.keys.methodkey,
  • cachetools.keys.typedkey.

Should be there the cachetools.keys.typedmethodkey? Thanks!
@tkem
Copy link
Owner

tkem commented Feb 25, 2024

@kuraga Thnaks for the input! typedkey is used in the cachetools.func wrappers, and nobody expressed any interest in a typedmethodkey so far. For the sake of completeness, however, this might be added.

@kuraga kuraga mentioned this issue Feb 26, 2024
Closed
@kuraga
Copy link
Contributor Author

kuraga commented Feb 26, 2024 •
edited
Loading

For the sake of completeness, however, this might be added.

Implemented in #301 #305.

@kuraga kuraga mentioned this issue Feb 27, 2024
Closed
@kuraga
Copy link
Contributor Author

kuraga commented Feb 27, 2024

New PR: #305.

tkem pushed a commit that referenced this issue Apr 10, 2024
@kuraga @tkem
Add the keys.typedmethodkey decorator
89c3009 
Closes: #296
tkem pushed a commit that referenced this issue May 1, 2024
@kuraga @tkem
Add the keys.typedmethodkey decorator
7637c0e 
Closes: #296
tkem pushed a commit that referenced this issue May 28, 2024
@kuraga @tkem
Add the keys.typedmethodkey decorator
f425346 
Closes: #296
@tkem tkem closed this as completed in e669b99 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkem tkem

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the keys.typedmethodkey decorator
Add the keys.typedmethodkey decorator
2 participants
@kuraga @tkem