Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Test Coverage #6

Open
bravetarget opened this issue Feb 20, 2020 · 3 comments
Open

Increase Test Coverage #6

bravetarget opened this issue Feb 20, 2020 · 3 comments
Labels
B HIGH PRIORITY (If active, product is shippable with minor workflow errors) good first issue Good for newcomers LOE 3 1-2 days

Comments

@bravetarget
Copy link
Collaborator

Problem or Request

The test coverage for the functions in this app is too low

Solution

Add more unit and integration tests to satisfy at least 50% coverage; ideally 80-100%

Additional context

Most of the tests being ran through health checks are just rendering passes

@bravetarget bravetarget added good first issue Good for newcomers B HIGH PRIORITY (If active, product is shippable with minor workflow errors) LOE 3 1-2 days labels Feb 20, 2020
@bravetarget bravetarget added this to the First sub-phase 2020 milestone Feb 20, 2020
@michalmikolajczyk
Copy link
Contributor

Do you think we should measure test coverage somehow?

@bravetarget
Copy link
Collaborator Author

bravetarget commented Feb 27, 2020

@michalmikolajczyk we discussed adding a test coverage module in the past when we were closing similar issues in our other apps. however, i think we concluded it wasn't necessary? although, maybe since this is an open source repository, we could put more effort towards setting that up. i will add this as an optional task for this issue for now

edit: actually, just checked and jest has a built in way to check coverage. passing the argument --collect-coverage will output a report that shows percentage of individual files and all files, pretty nice!

and as for this stencil project we can just run something like:
stencil test --spec --coverage to get a report that includes coverage

@michalmikolajczyk
Copy link
Contributor

that's awesome. We can automate by adding a check to the Travis CI file with a condition to pass only upon coverage > 50%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B HIGH PRIORITY (If active, product is shippable with minor workflow errors) good first issue Good for newcomers LOE 3 1-2 days
Projects
None yet
Development

No branches or pull requests

2 participants