Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent IDs lead to distributed computing woes. #111

Open
axelmagn opened this issue Mar 20, 2024 · 1 comment
Open

Inconsistent IDs lead to distributed computing woes. #111

axelmagn opened this issue Mar 20, 2024 · 1 comment

Comments

@axelmagn
Copy link

When trying to work with these data via Dataflow, I noticed a few things:

  • the ID field key is inconsistent between files. it is id in minhash and signals, doc_id in duplicates.
  • IDs are not present as an explicit field in documents. They must be reconstructed from the file path and line number.

This creates a lot of unnecessary friction when working with big data pipelines, since line number is not usually available. I'm finding myself writing a custom reader (sort of a bummer if you've ever had to do it).

For future data releases, please consider embedding a consistent key between all file groups for easier joining at scale. Just a UUID would be fine.

@mauriceweber
Copy link
Collaborator

Hi @axelmagn thanks for your feedback, these are very good points and is something we will definitely do in future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants