Feature-request (or question): Issues by category #19
Comments
|
I think your idea with IssueType is good. Should be easy to implement and Issue #6 is sort of related. It is something that may be solved with an I think both can be implemented.
|
|
Sort of yes. Our code base is not structured in such a way that we can use filetypes or folders though. A single commit might touch files in many different modules. Another way would be to add a |
|
Thanks for implementing it. Looks really nice! I pulled the changes and tried it out. Formatted the way I imagined. |
|
I added title attribute to custom issues. WIth support for variables. To avoid the empty subject-lines that you found in the PR. Perhaps it can be released like this, if you dont have any other thoughts? |
|
I'm not sure how the Title value resolves it. Still getting the same result. Here's what I am using to experiment with so you can see what I see: Repo: https://github.com/neo4j/neo4j.git changelog.json: {
"templatePath": "changelog.json",
"fromRepo": ".",
"fromCommit": "4bbf2b543a0f04e496fab0e023ad385976924322",
"toRef": "refs/remotes/origin/3.0",
"ignoreCommitsIfMessageMatches": "^\\[maven-release-plugin\\].*|^\\[Gradle Release Plugin\\].*|^Merge.*",
"readableTagName": "/([^/]+?)$",
"dateFormat": "YYYY-MM-dd HH:mm:ss",
"untaggedName": "Next release",
"noIssueName": "Other changes",
"timeZone": "UTC",
"removeIssueFromMessage": "false",
"_comment_gitHubApi": "https://api.github.com/repos/neo4j/neo4j",
"_comment_gitHubIssuePattern": "#([0-9]+)",
"customIssues": [
{ "name": "Incident", "pattern": "INC[0-9]*", "link": "http://inc/${PATTERN_GROUP}" },
{ "name": "CQ", "pattern": "CQ([0-9]+)", "link": "http://cq/${PATTERN_GROUP_1}" },
{ "name": "Bugs", "pattern": "#bug" },
{ "name": "Import tool", "pattern": "#import-tool.*#([0-9]+)|#([0-9]+).*#import-tool" },
{ "name": "Cypher", "pattern": "cypher"},
{ "name": "Consistency checker", "pattern": "consistency checker"},
{ "name": "Bolt", "pattern": "bolt"},
{ "name": "HA", "pattern": "\bha\b|cluster"},
{ "name": "Packaging", "pattern": "powershell"},
{ "name": "NestedTest", "pattern": "index.*#([0-9]+)|#([0-9+]).*index", "link": "https://github.com/neo4j/neo4j/issues/${PATTERN_GROUP_1}"}
]
}changelog.mustache: And for what it's worth, this is what I am trying to approximate: UPDATE: Fixed mustache template |
|
Your second paste there should have been a mustache template right? =) to: |
|
Oh right. Fixed that.. But still, it doesn't change the empty 'Other fixes' section. With your suggested changes: config: {
"templatePath": "changelog.json",
"fromRepo": ".",
"fromCommit": "4bbf2b543a0f04e496fab0e023ad385976924322",
"toRef": "refs/remotes/origin/3.0",
"ignoreCommitsIfMessageMatches": "^\\[maven-release-plugin\\].*|^\\[Gradle Release Plugin\\].*|^Merge.*",
"readableTagName": "/([^/]+?)$",
"dateFormat": "YYYY-MM-dd HH:mm:ss",
"untaggedName": "Next release",
"noIssueName": "Other changes",
"timeZone": "UTC",
"removeIssueFromMessage": "false",
"_comment_gitHubApi": "https://api.github.com/repos/neo4j/neo4j",
"_comment_gitHubIssuePattern": "#([0-9]+)",
"customIssues": [
{ "name": "Incident", "pattern": "INC[0-9]*", "link": "http://inc/${PATTERN_GROUP}" },
{ "name": "CQ", "pattern": "CQ([0-9]+)", "link": "http://cq/${PATTERN_GROUP_1}" },
{ "name": "Bugs", "title":"Bugs", "pattern": "#bug" },
{ "name": "Import tool", "title": "${PATTERN_GROUP}", "pattern": "#import-tool.*#([0-9]+)|#([0-9]+).*#import-tool" },
{ "name": "Cypher", "pattern": "cypher"},
{ "name": "Consistency checker", "pattern": "consistency checker"},
{ "name": "Bolt", "pattern": "bolt", "title": "HA ${PATTERN_GROUP}"},
{ "name": "HA", "pattern": "\bha\b|cluster", "title": "HA ${PATTERN_GROUP}"},
{ "name": "Packaging", "pattern": "powershell"},
{ "name": "NestedTest", "pattern": "index.*#([0-9]+)|#([0-9+]).*index", "link": "https://github.com/neo4j/neo4j/issues/${PATTERN_GROUP_1}"}
]
}template: Gives the following result: Still an empty "Other changes" section in there as you see. The customTitle feature thing is really useful though, (didn't realise how important this was previously). As it allows one to write commit messages which include stuff like:
But you know what would solve it (maybe it already exists?), a |
|
Actually, in your first template, there are issues and commits in These issues only has a The issueType can never be empty. It it is there, then there are issues in it. |
|
Sure, but I dont want to list every commit. Every release will have On Sat, Mar 19, 2016, 18:13 Tomas Bjerre [email protected] wrote:
|
|
You can use the |
|
Sure. But it feels a bit redundant, as it will simply be the AND of each On Sat, Mar 19, 2016, 21:27 Tomas Bjerre [email protected] wrote:
|
|
Is you use case as simple as "only include commits that are mapped by at least one issue" ? =) |
|
Exactly :) |
|
Its in master now. I'll release it tomorrow. |
|
This is released now, ok to close the issue? |
|
I think so On Sun, Mar 20, 2016, 11:40 Tomas Bjerre [email protected] wrote:
|
Not sure if this is currently possible, but I am trying to achieve a changelog with categories, where each category is an issue source (each category is a custom issue). For example, the result I want is along these lines:
To achieve this, I think you need to add under
tagsan item such asIssueTypes, where each type then has anameandissues.Alternatively, the concept of a category could be a completely independent thing which you specify manually.
What do you think? Is there an easier way to achieve this with the existing implementation?
The text was updated successfully, but these errors were encountered: