Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve music experience #686

Open
33KK opened this issue Oct 9, 2023 · 13 comments
Open

Improve music experience #686

33KK opened this issue Oct 9, 2023 · 13 comments

Comments

@33KK
Copy link

33KK commented Oct 9, 2023

@tomasklaen
Copy link
Owner

Audio indicator was quick and easy, but displaying meta will be a bit more involved and require new options, so I'll leave it for some time later.

@christoph-heinrich
Copy link
Contributor

I don't see why this has to be part of uosc, one can simply use a different script in combination with uosc.

@christoph-heinrich
Copy link
Contributor

Great...
image

@dyphire
Copy link
Contributor

dyphire commented Oct 9, 2023

I also don't understand what is preventing you using other scripts in combination with uosc.

@NaiveInvestigator
Copy link

same i also personally use vc-01/metadata-osd alongside with uosc for audio.

@tomasklaen
Copy link
Owner

I do think that it is valuable and a uosc's concern to indicate to the user there is no video. It's a difference between user thinking "this part of the video is black", and "there is no video".

But it of course should be replaceable with an equalizer script or something similar. That'll be possible with disable_elements=audio_indicator option once I get around to adding it.

And I see that there are good scripts for displaying meta, so I won't be adding that in.

@33KK
Copy link
Author

33KK commented Oct 9, 2023

I also don't understand what is preventing you using other scripts in combination with uosc.

I'm only aware of metadata-osd, which doesn't exactly look amazing.

I was thinking of something like this:
image metadata_osd doesn't allow for left margin settings and this needs dynamic video-margin-ratio calculation to keep margin equal on top/bottom and right. I guess I'll try throwing something together myself

tomasklaen added a commit that referenced this issue Oct 12, 2023
…essage

Allows disabling elements and various indicators by adding their IDs to the list:

```conf
disable_elements=timeline,audio_indicator
```

Also includes a new script message listener `disable-elements`, that does the same thing:

```lua
local id = mp.get_script_name()
mp.commandv('script-message-to', 'uosc', 'disable-elements', id, 'timeline,audio_indicator')
```

It'll register what elements each script wants disabled. The element will be enabled only when it is not disabled by neither user nor any script.

To cancel or re-enable the elements, just pass an empty list:

```lua
mp.commandv('script-message-to', 'uosc', 'disable-elements', id, '')
```

ref #686, closes #592
tomasklaen added a commit that referenced this issue Oct 14, 2023
…essage (#695)

* feat: added `disable_elements` option and `disable-elements` script message

Allows disabling elements and various indicators by adding their IDs to the list:

```conf
disable_elements=timeline,audio_indicator
```

Also includes a new script message listener `disable-elements`, that does the same thing:

```lua
local id = mp.get_script_name()
mp.commandv('script-message-to', 'uosc', 'disable-elements', id, 'timeline,audio_indicator')
```

It'll register what elements each script wants disabled. The element will be enabled only when it is not disabled by neither user nor any script.

To cancel or re-enable the elements, just pass an empty list:

```lua
mp.commandv('script-message-to', 'uosc', 'disable-elements', id, '')
```

ref #686, closes #592
@mrfragger
Copy link

mrfragger commented Jan 14, 2024

I only listen to audiobooks with transcribed subtitles and always enable metadata for all audio but not for video. Most important for me was to always show the current chapter playing which it does. Here's a screenshot of what it looks like playing a song. Only downside is if you try to use dual subs the one on top it blocks. When mpv 0.38 comes out there'll be a --secondary-sub-pos to deal with this however.

in script-opts/usoc.conf

top_bar=always
top_bar_size=40
top_bar_controls=no
top_bar_title=yes
top_bar_alt_title=${time-remaining} (${percent-pos}%) ${filename/no-ext}
top_bar_alt_title_place=below
top_bar_flash_on=video,audio
top_bar_persistency=audio

audiometadata

@zaeboba
Copy link

zaeboba commented Jul 23, 2024

Could you please share the settings? Very interesting icons on the panel and what they do

I only listen to audiobooks with transcribed subtitles and always enable metadata for all audio but not for video. Most important for me was to always show the current chapter playing which it does. Here's a screenshot of what it looks like playing a song. Only downside is if you try to use dual subs the one on top it blocks. When mpv 0.38 comes out there'll be a --secondary-sub-pos to deal with this however.

in script-opts/usoc.conf

top_bar=always
top_bar_size=40
top_bar_controls=no
top_bar_title=yes
top_bar_alt_title=${time-remaining} (${percent-pos}%) ${filename/no-ext}
top_bar_alt_title_place=below
top_bar_flash_on=video,audio
top_bar_persistency=audio

audiometadata

Could you please share the settings? Very interesting icons on the panel and what they do

@mrfragger
Copy link

mrfragger commented Jul 30, 2024

@zaeboba

Here is my mpv config and extensions for Mac. If you are on Linux or Windows I can send you a config for that. Quick PDF showing some of the options and uosc menu. I use mpv 0.38 on mac and compiled it. Not sure why people don't just share a binary for it. brew install stolendata version only has 0.37 and hogs up cpu / gpu. 0.38 runs smooth when compiled for apple silicon mac m1.

@zaeboba
Copy link

zaeboba commented Jul 31, 2024

@mrfragger

If you are on Linux or Windows I can send you a config for that.

if you would be so kind (Win and Lin)

I was wondering how you have implemented such bookmarks and history menu, I thought maybe somehow you can put this in there - https://github.com/Eisa01/mpv-scripts/tree/master
but apparently these scripts are all yours personally.
Too bad I don't know anything about writing scripts like this.

@mrfragger
Copy link

@zaeboba
I actually deleted the bookmark script I was using as a searchable History which keeps track of last played position pretty much does the job. I've tried that simple bookmark before and can't recall why I didn't use it. Think it was I couldn't get the glyphs to display with the font I was using. Anyway here's the current mpv custom config and PDF is included with instructions for Mac, Linux or Windows. I didn't test on Windows just Mac and Linux though.
mpvconfiggeektips082024.zip 4MB

@zaeboba
Copy link

zaeboba commented Aug 7, 2024

@mrfragger

I actually deleted the bookmark script

That's too bad. I use it a lot.
I'll take it from the last mac file, hopefully it will work.

thanks!

Even though you removed more than half of the scripts, the rest of the scripts still don't work on Windows. 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants