Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibility #86

Open
3 tasks
ShaunSHamilton opened this issue Apr 19, 2023 · 2 comments
Open
3 tasks

accessibility #86

ShaunSHamilton opened this issue Apr 19, 2023 · 2 comments

Comments

@ShaunSHamilton
Copy link
Contributor

Would admonish be interested in improving the accessibility of the generated HTML and CSS?

  • details elements are missing indication they are clickable (e.g. details:hover { cursor: pointer; })
  • Admonish blocks should contain sr-only titles for blocks without titles
  • Block titles should be included in aria-labels, and/or use semantic elements (e.g. header maybe)
@tommilligan
Copy link
Owner

Yes, very open to improving this.

Could you add a link to a reference for these attributes/general overview on the requirements? I don't have a lot of accessibility experience.

@ShaunSHamilton
Copy link
Contributor Author

Relevant links:

If you do not like those docs, then Mozilla's are probably also more than enough: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles

Other than that, it would take some research on my part as to what a note/warning/quote/bug/example should indicate. Whether they should all have the same structure, or be specific to the directive. 🤷‍♂️

I do not have much a11y experience either. The top mentioned things are just what I want in a project I am writing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants