Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows CI workflow #142

Open
gabriel-samfira opened this issue Nov 11, 2022 · 0 comments
Open

Add Windows CI workflow #142

gabriel-samfira opened this issue Nov 11, 2022 · 0 comments

Comments

@gabriel-samfira
Copy link
Contributor

The tests on Windows for a number of packages seem to fail. A lot of them are a simple fix of just doing a filepath.FromSlash() on expected paths, but some are legitimately failing. Looking at the tested code that fails. Looks like most of it is in regards to following symlinks or walking paths.

As this code is being used in buildkit in https://github.com/moby/buildkit/blob/master/cache/util/fsutil.go#L99, this will have to be fixed before we can safely add Windows support to builkit.

Looking into it now, and will post back an update as soon as I have something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant