Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect.action.timeline.adjusted is not handled #72

Open
maxceem opened this issue Oct 22, 2018 · 6 comments
Open

connect.action.timeline.adjusted is not handled #72

maxceem opened this issue Oct 22, 2018 · 6 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Oct 22, 2018

connect.action.timeline.adjusted event is generated in tc-project-service https://github.com/topcoder-platform/tc-project-service/blob/dev/src/constants.js#L104 and is handled in connect-app https://github.com/appirio-tech/connect-app/blob/dev/src/routes/notifications/constants/notifications.js#L509.

But it's not handled in tc-notifications thus won't appear in connect-app.

@maxceem
Copy link
Contributor Author

maxceem commented Oct 23, 2018

@vikasrohit FYI, I'll send this event connect.action.timeline.adjusted only to copilot/manager users. Let me know if owner/member also have to get it.

@vikasrohit
Copy link

I guess, as this notification is going to be hidden for all users, we can listen it for all users. It would allows us to show the visual cue for customers as well which I think is more important because mostly it would a copilot/manager who would be doing the changes and customer needs to know that there is a change in the timeline.

@maxceem
Copy link
Contributor Author

maxceem commented Oct 23, 2018

@vikasrohit created a PR #73

vikasrohit pushed a commit that referenced this issue Oct 23, 2018
issue #72 - connect.action.timeline.adjusted is not handled
@vikasrohit
Copy link

@maxceem PR is merged, let me know if you are still seeing any issue with this event.

@maxceem
Copy link
Contributor Author

maxceem commented Jan 17, 2019

@vikasrohit by the code it seems everything is ok, but this event connect.action.timeline.adjusted doesn't come to me in Connect app, even though I can see this event is generated by tc-project-service. I've tried to reproduce it locally by deploying tc-notification, but it depends on tc-project-service so it's a little bit hard to test it locally.

@maxceem
Copy link
Contributor Author

maxceem commented Apr 9, 2019

@vikasrohit this event comes to Connect now. So this issue is fully resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants