Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after upgrade to v2, environment not work #244

Closed
greatcat-taihe opened this issue Aug 31, 2021 · 1 comment
Closed

after upgrade to v2, environment not work #244

greatcat-taihe opened this issue Aug 31, 2021 · 1 comment

Comments

@greatcat-taihe
Copy link

when v1, i use env PITAYA_CLUSTER_SD_ETCD_ENDPOINTS, PITAYA_CLUSTER_RPC_CLIENT_NATS_CONNECT, PITAYA_CLUSTER_RPC_SERVER_NATS_CONNECT.
After upgrade to pitaya v2, i must write some code like this

	etcdConf := *config.NewDefaultEtcdServiceDiscoveryConfig()
	etcdConf.Endpoints = pitayaConf.GetStringSlice("pitaya.cluster.sd.etcd.endpoints")
	etcdConf.User = pitayaConf.GetString("pitaya.cluster.sd.etcd.user")
	etcdConf.Pass = pitayaConf.GetString("pitaya.cluster.sd.etcd.pass")
	builder.ServiceDiscovery, err = cluster.NewEtcdServiceDiscovery(etcdConf, builder.Server, builder.DieChan)
@henriqueoelze
Copy link
Contributor

Hello @greatcat-taihe ,
Pitaya v2 is a breaking change release, as mentioned in the #240.
We have in our roadmap a task to write a migration guide to help all users to migrate to it, but with that in mind, it is not compatible with Pitaya projects written with Pitaya v1.

If you prefer, you can continue to use Pitaya v1 with no problem, and we will follow the roadmap described in the issue about fixes, new features, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants