Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BoxCloneSyncService #770

Open
tthebst opened this issue Jun 3, 2024 · 3 comments · May be fixed by #777
Open

Add BoxCloneSyncService #770

tthebst opened this issue Jun 3, 2024 · 3 comments · May be fixed by #777
Labels
A-util Area: The tower "util" module C-feature-request Category: A feature request, i.e: not implemented / a PR.

Comments

@tthebst
Copy link

tthebst commented Jun 3, 2024 •
edited
Loading

Currently BoxCloneService does not implement Sync even though the inner Service implements Sync. This can be solved by adding a Sync bound to the inner service bounds.

Other projects such as axum also have this just internally. Might be worth adding it upstream.

I would be willing to submit a PR for this.
@tobz
Copy link
Member

tobz commented Jul 21, 2024

@tthebst Yeah, looking at what axum does... it seems like that ought to be fine.

If you're willing to submit a PR, that'd be great.

@tobz tobz added A-util Area: The tower "util" module C-feature-request Category: A feature request, i.e: not implemented / a PR. relnotes Marks issues that should be documented in the release notes of the next release. and removed relnotes Marks issues that should be documented in the release notes of the next release. labels Jul 21, 2024
@GlenDC
Copy link
Contributor

GlenDC commented Jul 21, 2024

If you no longer can pick this work up @tthebst in the next weeks do let us know. I can take it over if you wish. Otherwise I’ll leave it with pleasure for you to do, given it was your proposal :)

@tthebst tthebst linked a pull request Jul 22, 2024 that will close this issue
Open
@alekseysidorov
Copy link

If you want to use this functionality, I have added it to my crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-util Area: The tower "util" module C-feature-request Category: A feature request, i.e: not implemented / a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add BoxCloneSyncService tthebst/tower
4 participants
@alekseysidorov @tobz @GlenDC @tthebst