From 243cefb250889fba3875f62ad6ba50d707a1b3bf Mon Sep 17 00:00:00 2001 From: Thomas Polasek Date: Fri, 18 Oct 2024 08:45:56 -0700 Subject: [PATCH] Convert directory fbcode/opensource to use the Ruff Formatter Summary: X-link: https://github.com/facebookexperimental/moxygen/pull/3 X-link: https://github.com/facebookexperimental/edencommon/pull/21 X-link: https://github.com/facebook/watchman/pull/1248 X-link: https://github.com/facebook/wangle/pull/239 X-link: https://github.com/facebook/sapling/pull/968 X-link: https://github.com/facebook/proxygen/pull/523 X-link: https://github.com/facebook/openr/pull/156 X-link: https://github.com/facebook/mvfst/pull/358 X-link: https://github.com/facebook/hhvm/pull/9522 X-link: https://github.com/facebook/folly/pull/2318 X-link: https://github.com/facebook/fboss/pull/277 X-link: https://github.com/facebook/fb303/pull/59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365 --- build/fbcode_builder/CMake/fb_py_test_main.py | 4 ---- build/fbcode_builder/CMake/make_fbpy_archive.py | 4 +--- build/fbcode_builder/getdeps/builder.py | 1 - build/fbcode_builder/getdeps/buildopts.py | 1 - build/fbcode_builder/getdeps/cargo.py | 4 +--- build/fbcode_builder/getdeps/dyndeps.py | 4 +--- 6 files changed, 3 insertions(+), 15 deletions(-) diff --git a/build/fbcode_builder/CMake/fb_py_test_main.py b/build/fbcode_builder/CMake/fb_py_test_main.py index a9499e221..edba549bd 100644 --- a/build/fbcode_builder/CMake/fb_py_test_main.py +++ b/build/fbcode_builder/CMake/fb_py_test_main.py @@ -6,7 +6,6 @@ This file contains the main module code for Python test programs. """ - import contextlib import ctypes import fnmatch @@ -50,7 +49,6 @@ def read(self): class TestStatus(object): - ABORTED = "FAILURE" PASSED = "SUCCESS" FAILED = "FAILURE" @@ -230,7 +228,6 @@ def _find_next_test(self, suite): """ for test in suite: - # We identify test suites by test that are iterable (as is done in # the builtin python test harness). If we see one, recurse on it. if hasattr(test, "__iter__"): @@ -429,7 +426,6 @@ def getTestCaseNames(self, testCaseClass): class Loader(object): - suiteClass = unittest.TestSuite def __init__(self, modules, regex=None): diff --git a/build/fbcode_builder/CMake/make_fbpy_archive.py b/build/fbcode_builder/CMake/make_fbpy_archive.py index 3724feb21..42c1fac61 100755 --- a/build/fbcode_builder/CMake/make_fbpy_archive.py +++ b/build/fbcode_builder/CMake/make_fbpy_archive.py @@ -156,9 +156,7 @@ def create_main_module(args, inst_dir, path_map): if __name__ == "__main__": import {main_module} {main_module}.{main_fn}() -""".format( - python=args.python, main_module=main_module, main_fn=main_fn - ) +""".format(python=args.python, main_module=main_module, main_fn=main_fn) with open(dest_path, "w") as f: f.write(main_contents) os.chmod(dest_path, 0o755) diff --git a/build/fbcode_builder/getdeps/builder.py b/build/fbcode_builder/getdeps/builder.py index 6ad9f2859..697ac3f91 100644 --- a/build/fbcode_builder/getdeps/builder.py +++ b/build/fbcode_builder/getdeps/builder.py @@ -286,7 +286,6 @@ def _get_prefix(self): return ["PREFIX=" + self.inst_dir, "prefix=" + self.inst_dir] def _build(self, reconfigure) -> None: - env = self._compute_env() # Need to ensure that PREFIX is set prior to install because diff --git a/build/fbcode_builder/getdeps/buildopts.py b/build/fbcode_builder/getdeps/buildopts.py index b315c175b..e3aec02db 100644 --- a/build/fbcode_builder/getdeps/buildopts.py +++ b/build/fbcode_builder/getdeps/buildopts.py @@ -128,7 +128,6 @@ def __init__( self.lib_path = lib_path if vcvars_path is None and is_windows(): - try: # Allow a site-specific vcvarsall path. from .facebook.vcvarsall import build_default_vcvarsall diff --git a/build/fbcode_builder/getdeps/cargo.py b/build/fbcode_builder/getdeps/cargo.py index cae8bf54c..9033778d2 100644 --- a/build/fbcode_builder/getdeps/cargo.py +++ b/build/fbcode_builder/getdeps/cargo.py @@ -112,9 +112,7 @@ def _create_cargo_config(self): [profile.dev] debug = false incremental = false -""".format( - self.build_dir.replace("\\", "\\\\") - ) +""".format(self.build_dir.replace("\\", "\\\\")) # Point to vendored sources from getdeps manifests for _dep, git_conf in dep_to_git.items(): diff --git a/build/fbcode_builder/getdeps/dyndeps.py b/build/fbcode_builder/getdeps/dyndeps.py index 25e15cd36..cf2c91090 100644 --- a/build/fbcode_builder/getdeps/dyndeps.py +++ b/build/fbcode_builder/getdeps/dyndeps.py @@ -328,9 +328,7 @@ def _get_dev_run_script_contents(self, path_dirs) -> str: }} finally {{ $env:PATH = $orig_env }} -""".format( - path_str=path_str - ) +""".format(path_str=path_str) class ElfDeps(DepBase):