Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing of @mentions to not include e-mail addresses #6

Open
toebu opened this issue Mar 18, 2015 · 1 comment
Open

Improve parsing of @mentions to not include e-mail addresses #6

toebu opened this issue Mar 18, 2015 · 1 comment
Labels

Comments

@toebu
Copy link
Contributor

toebu commented Mar 18, 2015

If your comment contains an e-mail address ([email protected]) it will add "@example" to the CC. This should not happen. It should either add the whole e-mail address as a CC, or nothing at all. It would be great to be able to switch between these two modes in the config (some Trac instances use e-mail addresses as users, others don't).
In general the parsing should be improved to require a space or the beginning of a line before the "@" (and maybe also at the end of the name).

@CaptSpot CaptSpot added the bug label Mar 18, 2015
@pfiaux
Copy link

pfiaux commented Mar 20, 2015

We could extend this to only update the cc if the target of the mention is one of the trac users. Then it wouldn't include non users which could be many use cases:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants