Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cell's name instead of controller_path in cache key generation #494

Closed
wants to merge 1 commit into from
Closed

Use cell's name instead of controller_path in cache key generation #494

wants to merge 1 commit into from

Conversation

yogeshjain999
Copy link
Member

Fixes #491

Note that this change doesn't remove Cell or ::Cell from cell's name, as it is being done in controller_path. I think controller_path is independent of cache key generation, though this is open for discussion.

# Old behaviour

class DirectorCell < Cell::ViewModel
  cache :show # cache key => "director/count/"
end
# New behaviour

class DirectorCell < Cell::ViewModel
  cache :show # cache key => "director_cell/count/"
end

@yogeshjain999 yogeshjain999 requested a review from apotonick June 13, 2021 18:39
@yogeshjain999 yogeshjain999 force-pushed the fix/cache-key-generation branch from 264bd61 to e6f99eb Compare June 13, 2021 18:42
@yogeshjain999 yogeshjain999 mentioned this pull request Jun 13, 2021
Open
@yogeshjain999
Copy link
Member Author

Closing this in reference to trailblazer/trailblazer-cells#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apotonick apotonick Awaiting requested review from apotonick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default cache key produces clashes
1 participant
@yogeshjain999