Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - TXJS File Parser incorrectly parses text on certain occasions #197

Open
mark-hopper opened this issue Nov 1, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@mark-hopper
Copy link

Current Behavior
The text which is pushed to Transifex via the CDS contains all the attributes (such as count, id, link, text)

Expected Behavior
The text pushed to Transifex via the CDS contains only the data passed to the translate pipe (e.g. 'Security')

Steps to Reproduce
Produce a html template which contains the following code snippet
<ng-container *ngIf="!data.equipment.manual && alertSettings.enableSecurity"> <ng-container *ngTemplateOutlet="el; context: { count: data.security?.length, id: 'assetpage-actionstab-securitytab-button', link: ['/fleet', data.equipment.id, 'actions', 'security'], text: ('Security' | translate:{ _key: 'text.asset_details.tab.security', _tags: 'asset_details' }), }"></ng-container> </ng-container>

Use the TXJS push mechanic to parse the file and look at the end outcome which is pushed to Transifex.

Possible Solution
My suspicions here, is that the brackets on the "text" property have potentially thrown the parser - Either that or the use of the ngTemplateOutlet in this manner.

Possible Implementation
Not obligatory, but suggest an idea for implementing addition or change

@mark-hopper mark-hopper added the bug Something isn't working label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant