Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chart.js to 4.x #38

Open
devinmatte opened this issue Feb 10, 2023 · 1 comment
Open

Update Chart.js to 4.x #38

devinmatte opened this issue Feb 10, 2023 · 1 comment

Comments

@devinmatte
Copy link
Member

devinmatte commented Feb 10, 2023

We would love to bring this ridership data into the data dashboard, but, right now the charts here are using quite an old version of chart.js. It would help the migration of these charts a lot if they're using the same chart.js version here, instead of trying to migrate to chart.js 4.x at the same time as migrating the components

Even in a world where we have this data available in the data dashboard, it may be a while until we have all the data so this upgrade should still be worthwhile

https://www.chartjs.org/docs/3.9.1/getting-started/v3-migration.html#_3-x-migration-guide

@devinmatte
Copy link
Member Author

I started this fix in #39, still needs a little cleanup, but should fix a large amount of the problems. Still needs a followup to 4.x, but, the 2 -> 3 jump is more significant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant