Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial anchor links fail when opened in a new tab #824

Open
JLKwong opened this issue Feb 8, 2021 · 1 comment
Open

Tutorial anchor links fail when opened in a new tab #824

JLKwong opened this issue Feb 8, 2021 · 1 comment

Comments

@JLKwong
Copy link
Member

JLKwong commented Feb 8, 2021

Problem

In Step 3, GitHub and Markdown, the anchor links for the summary of the steps will open an invalid page if opened in a new tab.

Steps to reproduce the problem

  1. Go to the GitHub and Markdown tutorial
  2. Find the links under Start Here
  3. Right-click or middle-click (with the scroll-wheel) one of the links to open it in a new tab.

Screenshots

image
image
image

Proposed solution

N/A (I don't know how to resolve this in HTML/MDwiki)

@JLKwong JLKwong changed the title Tutorial anchor links fail when opened a new tab Tutorial anchor links fail when opened in a new tab Feb 8, 2021
@rjpadilla
Copy link
Member

I have several ideas on whats going on

  • The anchor is pointing ./pages/vi/#Login_to_GitHub_with_your username_and_password, which is a relative path..
  • So when you try to open by tab it goes treehouses.io/pages/vi/#Login_to_GitHub_with_your username_and_password
  • As you can tell by the url name, there is no such file in the treehouses.io directory.
  • Plus the anchor is using jQuery event handlers.

So I don't know how strong your jQuery skills (its like Javascript + DOM), but I would probably start in treehouses.github.io/mdwiki/js/. Start with the util.js file and move my way up through the /js/ directory and see what would finally make it work.

Though I honestly don't know if we are allowed to modify the MDwiki template. So you may want to ask @dogi or the Systems team before preceding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants