-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log SKIP_EMBER when true in Development #566
Comments
If interested, I would be more than happy to work on a PR, it would be a feature that could likely save our team time in the future. |
@Samsinite I like this idea! How would we structure the communication of how the application is configured?
|
Honestly, I haven't put a lot of thought into the structure of the log message. What would you prefer the log message to look like or say? |
I'm less focussed on the structure of the log message, and more thinking about when and how it should be communicated.
At what point in the process would some indication that |
What about adding a check for Thoughts? Unless I am mistaken, the current gem structure should make this feature fairly straight forward. |
Or, if we should just warn regardless when in development, we could add a method that does the check and warn if true, then call it in https://github.com/thoughtbot/ember-cli-rails/blob/989e6101277c7ef35bfb02e47cefbc6da656dd6a/lib/ember_cli/deploy/file.rb#L19 Seems like it could still be useful to warn, even if the build is successful. |
Hi, at work we love this gem and appreciate the hard work that has been put into it.
Just ran into an issue where a co-worker accidentally had
SKIP_EMBER=true
in development, and it took us 20 minutes to track down. I was thinking that it would be useful to log to the server thatSKIP_EMBER=true
when in development and there is a build error, thoughts?The text was updated successfully, but these errors were encountered: