Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise 2.4.1.C was changed, but the corresponding Rust file was not updated accordingly? #130

Open
michielp1807 opened this issue Aug 27, 2024 · 0 comments

Comments

@michielp1807
Copy link
Contributor

michielp1807 commented Aug 27, 2024

It seems that the original 2.4.1.C was removed some time ago in this merge. However, the test case for the old 2.4.1.C is still in the Rust file, causing the test cases to be mislabeled, while the exercises skip from C to E.

Furthermore, some test cases from the other exercises use the as_ref() functionality that was supposed to be implemented by the old 2.4.1.C, which means that these test cases do not work unless you implement as_ref() yourself without the hints and explanations from the original 2.4.1.C.

Some other smaller issues with 2.4.1:

  • There's a typo in the comment for the test it_compiles: "as is can never"
  • The it_removes test for the .remove function calls dbg!(&vec), but the Debug trait is not implemented or explained in the exercise (this line could just be removed, or we could derive the Debug trait for LocalStorageVec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant