From 1af39e87aab3736e6b1b333c43257cd8311dd7c4 Mon Sep 17 00:00:00 2001 From: kthui <18255193+kthui@users.noreply.github.com> Date: Wed, 23 Oct 2024 12:22:21 -0700 Subject: [PATCH 1/3] Add small delay after reloading model versions --- qa/L0_lifecycle/lifecycle_test.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/qa/L0_lifecycle/lifecycle_test.py b/qa/L0_lifecycle/lifecycle_test.py index 49fe684ff1..6f601f8d26 100755 --- a/qa/L0_lifecycle/lifecycle_test.py +++ b/qa/L0_lifecycle/lifecycle_test.py @@ -3531,6 +3531,7 @@ def test_load_new_model_version(self): f.write(config) # reload the model client.load_model(model_name) + time.sleep(0.2) # version 1 is unmodified so it should not be reloaded # version 2 is modified so it should be reloaded @@ -3552,6 +3553,7 @@ def test_load_new_model_version(self): Path(os.path.join("models", model_name, "dummy_dependency.py")).touch() # reload the model client.load_model(model_name) + time.sleep(0.2) # all 4 versions should be reloaded self.assertTrue(client.is_model_ready(model_name, "1")) @@ -3579,6 +3581,7 @@ def test_load_new_model_version(self): f.write(config) # reload the model client.load_model(model_name) + time.sleep(0.2) # only version 4 should be available and no reloads should happen self.assertFalse(client.is_model_ready(model_name, "1")) @@ -3606,6 +3609,7 @@ def test_load_new_model_version(self): f.write(config) # reload the model client.load_model(model_name) + time.sleep(0.2) # version 1 should be loaded and version 4 should not be reloaded self.assertTrue(client.is_model_ready(model_name, "1")) From 3ddf25b9534cc744ca14630eb00d950ec8e1633c Mon Sep 17 00:00:00 2001 From: kthui <18255193+kthui@users.noreply.github.com> Date: Thu, 24 Oct 2024 10:38:42 -0700 Subject: [PATCH 2/3] Revert "Add small delay after reloading model versions" This reverts commit 1af39e87aab3736e6b1b333c43257cd8311dd7c4. --- qa/L0_lifecycle/lifecycle_test.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/qa/L0_lifecycle/lifecycle_test.py b/qa/L0_lifecycle/lifecycle_test.py index 6f601f8d26..49fe684ff1 100755 --- a/qa/L0_lifecycle/lifecycle_test.py +++ b/qa/L0_lifecycle/lifecycle_test.py @@ -3531,7 +3531,6 @@ def test_load_new_model_version(self): f.write(config) # reload the model client.load_model(model_name) - time.sleep(0.2) # version 1 is unmodified so it should not be reloaded # version 2 is modified so it should be reloaded @@ -3553,7 +3552,6 @@ def test_load_new_model_version(self): Path(os.path.join("models", model_name, "dummy_dependency.py")).touch() # reload the model client.load_model(model_name) - time.sleep(0.2) # all 4 versions should be reloaded self.assertTrue(client.is_model_ready(model_name, "1")) @@ -3581,7 +3579,6 @@ def test_load_new_model_version(self): f.write(config) # reload the model client.load_model(model_name) - time.sleep(0.2) # only version 4 should be available and no reloads should happen self.assertFalse(client.is_model_ready(model_name, "1")) @@ -3609,7 +3606,6 @@ def test_load_new_model_version(self): f.write(config) # reload the model client.load_model(model_name) - time.sleep(0.2) # version 1 should be loaded and version 4 should not be reloaded self.assertTrue(client.is_model_ready(model_name, "1")) From ba226a358ea6cfb498a47ec5ce9cc78886ab774f Mon Sep 17 00:00:00 2001 From: kthui <18255193+kthui@users.noreply.github.com> Date: Thu, 24 Oct 2024 10:40:48 -0700 Subject: [PATCH 3/3] Add small delay after disk operation --- qa/L0_lifecycle/lifecycle_test.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/qa/L0_lifecycle/lifecycle_test.py b/qa/L0_lifecycle/lifecycle_test.py index 49fe684ff1..1dc659e27c 100755 --- a/qa/L0_lifecycle/lifecycle_test.py +++ b/qa/L0_lifecycle/lifecycle_test.py @@ -3529,6 +3529,8 @@ def test_load_new_model_version(self): f.truncate(0) f.seek(0) f.write(config) + # make sure the disk operation is done before reloading + time.sleep(0.1) # reload the model client.load_model(model_name) @@ -3550,6 +3552,8 @@ def test_load_new_model_version(self): # simulate a dependency change to all versions Path(os.path.join("models", model_name, "dummy_dependency.py")).touch() + # make sure the disk operation is done before reloading + time.sleep(0.1) # reload the model client.load_model(model_name) @@ -3577,6 +3581,8 @@ def test_load_new_model_version(self): f.truncate(0) f.seek(0) f.write(config) + # make sure the disk operation is done before reloading + time.sleep(0.1) # reload the model client.load_model(model_name) @@ -3604,6 +3610,8 @@ def test_load_new_model_version(self): f.truncate(0) f.seek(0) f.write(config) + # make sure the disk operation is done before reloading + time.sleep(0.1) # reload the model client.load_model(model_name)