Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated validators library version to be 0.18.1 #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kentoku24
Copy link

fix #54

0.12.0 does not treat punycoded URL.
The latest 0.18.1 correctly recognize punycoded URL.

example: https://xn--wmq0m700b.jp/h30

0.12.0 does not treat punycoded URL.
The latest 0.18.1 correctly recognize punycoded URL.
@itsojon
Copy link
Collaborator

itsojon commented Oct 6, 2020

@kentoku24 thanks again! Did this solution work for you locally? I still get that error and think this line needs to also be removed (though .strip()ing the destination should be retained):

destination = _encode_ascii_incompatible_chars(destination.strip())

I believe that scrubbing is a relic from when Trotto was using a different database and can now be removed. You'll also need to update related tests.

@kentoku24
Copy link
Author

thank you for the feedback. I will look into this too!

@itsojon
Copy link
Collaborator

itsojon commented Oct 7, 2020

Thank you @kentoku24! Don't hesitate to send me any questions.

@kentoku24
Copy link
Author

Sorry to take forever to reply to you, but how could I run the tests? I found e2e test but stuck at setting "secret".
Does trotto has unit tests that runs locally?

@kentoku24
Copy link
Author

@itsojon

Did this solution work for you locally? I still get that error and think this line needs to also be removed (though .strip()ing the destination should be retained):
It certainly worked in my local environment. Have you re-installed the libraries with pip command?

After bumping the version to 0.18.1
スクリーンショット 2021-08-22 23 18 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-links can not register Punycode-ed URL
3 participants