Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for platforms #53

Open
robin-nitrokey opened this issue Jun 22, 2024 · 0 comments
Open

Drop support for platforms #53

robin-nitrokey opened this issue Jun 22, 2024 · 0 comments
Milestone

Comments

@robin-nitrokey
Copy link
Member

Some parts of this crate try to accommodate both the authenticator side and the platform side, even though it is only used by fido-authenticator (at least on crates.io).

For example, many (or all?) request structs also implement Serialize even though authenticators will only deserialize requests, and vice versa for responses.

This increases the generated code, maintenance and test effort; and keeping compatibility for platforms can lead to suboptimal choices for authenticators. For example, for an authenticator, it is not necessary to handle unknown enum values in responses.

Therefore, I would like to drop support for platforms in ctap_types, at least until there is an actual demand for it. This mainly means dropping Serialize for requests and Deserialize for responses. Please let me know if you have any objections.

@robin-nitrokey robin-nitrokey added this to the v0.3.0 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant