Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subcircuit flipping #109

Open
2 tasks
seveibar opened this issue Sep 22, 2024 · 1 comment
Open
2 tasks

Subcircuit flipping #109

seveibar opened this issue Sep 22, 2024 · 1 comment

Comments

@seveibar
Copy link
Contributor

seveibar commented Sep 22, 2024

If someone specifies isFlipped on a subcircuit, it should flip every component to the bottom/opposite layer

  • isFlipped prop for subcircuits in tscircuit/props
  • Implementation for flipping subcircuit in core

Note: This feature is a bit more of a proposal, because higher order components could just take layer as a prop and perform the necessary adjustments in a possibly more robust way. Seems useful but depending on complexity we may punt it a bit

We may be able to implement this via a circuit json transformation since it's at the subcircuit boundary. In that case we'd want to implement something inside of soup-util to flip components

Copy link

homie-gg bot commented Sep 22, 2024

Here are some pull requests that might be helpful reference for this task:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant