Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseN2kPGN129540 isse #399

Open
cosina opened this issue Apr 21, 2024 · 0 comments
Open

ParseN2kPGN129540 isse #399

cosina opened this issue Apr 21, 2024 · 0 comments

Comments

@cosina
Copy link

cosina commented Apr 21, 2024

Parsing of PGN129540 checks for:

bool ret=( NumberOfSVs<MaxSatelliteInfoCount && SVIndex<NumberOfSVs );

But if NumberOfSVs is 18, then message is never parsed.

(Sample logLighthouse 4)

Tx 1297382 19 fa 04 08 a0 db 0a ff 12 03 69 03 From:08 GnssSatsInView 
Tx 1297382 19 fa 04 08 a1 f0 ed 98 08 00 00 00 From:08 GnssSatsInView 
Tx 1297382 19 fa 04 08 a2 00 f2 06 74 14 c5 22 From:08 GnssSatsInView 
Tx 1297382 19 fa 04 08 a3 08 07 00 00 00 00 f2 From:08 GnssSatsInView 
Tx 1297382 19 fa 04 08 a4 0b 97 1a d0 42 28 0a From:08 GnssSatsInView 
Tx 1297382 19 fa 04 08 a5 00 00 00 00 f2 0c b9 From:08 GnssSatsInView 
Tx 1297382 19 fa 04 08 a6 2f b9 3e 8c 0a 00 00 From:08 GnssSatsInView 
Tx 1297382 19 fa 04 08 a7 00 00 f2 13 69 03 68 From:08 GnssSatsInView 
Tx 1297382 19 fa 04 08 a8 21 c4 09 00 00 00 00 From:08 GnssSatsInView 
Tx 1297382 19 fa 04 08 a9 f2 18 46 0c 15 6d 54 From:08 GnssSatsInView 
Tx 1297383 19 fa 04 08 aa 0b 00 00 00 00 f2 19 From:08 GnssSatsInView 
Tx 1297383 19 fa 04 08 ab 7f 34 da bc b8 0b 00 From:08 GnssSatsInView 
Tx 1297384 19 fa 04 08 ac 00 00 00 f2 1c 2e 17 From:08 GnssSatsInView 
Tx 1297385 19 fa 04 08 ad f1 cf f0 0a 00 00 00 From:08 GnssSatsInView 
Tx 1297385 19 fa 04 08 ae 00 f2 1d 80 16 43 93 From:08 GnssSatsInView 
Tx 1297386 19 fa 04 08 af 48 0d 00 00 00 00 f2 From:08 GnssSatsInView 
Tx 1297386 19 fa 04 08 b0 1f 74 05 70 d7 c4 09 From:08 GnssSatsInView 
Tx 1297388 19 fa 04 08 b1 00 00 00 00 f1 20 0b From:08 GnssSatsInView 
Tx 1297389 19 fa 04 08 b2 11 43 b1 34 08 00 00 From:08 GnssSatsInView 
Tx 1297389 19 fa 04 08 b3 00 00 f2 45 51 0e 65 From:08 GnssSatsInView 
Tx 1297390 19 fa 04 08 b4 c6 28 0a 00 00 00 00 From:08 GnssSatsInView 
Tx 1297390 19 fa 04 08 b5 f1 46 8b 09 07 f2 00 From:08 GnssSatsInView 
Tx 1297391 19 fa 04 08 b6 00 00 00 00 00 f0 4d From:08 GnssSatsInView 
Tx 1297392 19 fa 04 08 b7 23 15 b9 4d 00 00 00 From:08 GnssSatsInView 
Tx 1297393 19 fa 04 08 b8 00 00 00 f0 4f c5 13 From:08 GnssSatsInView 
Tx 1297394 19 fa 04 08 b9 93 ce 80 0c 00 00 00 From:08 GnssSatsInView 
Tx 1297394 19 fa 04 08 ba 00 f2 56 74 05 5d 10 From:08 GnssSatsInView 
Tx 1297395 19 fa 04 08 bb 98 08 00 00 00 00 f2 From:08 GnssSatsInView 
Tx 1297396 19 fa 04 08 bc 57 74 23 d1 24 54 0b From:08 GnssSatsInView 
Tx 1297397 19 fa 04 08 bd 00 00 00 00 f1 58 17 From:08 GnssSatsInView 
Tx 1297397 19 fa 04 08 be 22 67 6c f0 0a 00 00 From:08 GnssSatsInView 
Tx 1297399 19 fa 04 08 bf 00 00 f2 ff ff ff ff From:08 GnssSatsInView 

Proper condition should be:

bool ret=( NumberOfSVs<=MaxSatelliteInfoCount && SVIndex<NumberOfSVs );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant