Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Android face unlock - auto confirm and avoid "Press to Continue" #162

Open
3 tasks done
frabera opened this issue Aug 24, 2024 · 1 comment · May be fixed by #174
Open
3 tasks done

feat: Android face unlock - auto confirm and avoid "Press to Continue" #162

frabera opened this issue Aug 24, 2024 · 1 comment · May be fixed by #174
Labels
Feature New feature or request

Comments

@frabera
Copy link

frabera commented Aug 24, 2024

Feature description

Skip or provide an option to skip confirmation after Face unlock. The feature is controlled by setConfirmationRequired in the unlock prompt:

https://developer.android.com/reference/androidx/biometric/BiometricPrompt.PromptInfo.Builder#setConfirmationRequired(boolean)

Motivation

The confirmation after successful face unlock is unnecessary and this would speed up the access.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@frabera frabera added the Feature New feature or request label Aug 24, 2024
@frabera
Copy link
Author

frabera commented Aug 24, 2024

This can be implemented here:

2fas-android/feature/security/src/main/java/com/twofasapp/feature/security/ui/biometric/BiometricDialog.kt

Line 43 in 224fdbf

.build()

By adding .setConfirmationRequired(false) before calling build()

@victor-marino victor-marino linked a pull request Oct 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@frabera