Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Remove TypeDB runner --debug switch #70

Open
lolski opened this issue Dec 21, 2020 · 2 comments
Open

Remove TypeDB runner --debug switch #70

lolski opened this issue Dec 21, 2020 · 2 comments

Comments

@lolski
Copy link
Member

lolski commented Dec 21, 2020

TypeDB can be ran in debug mode, in which it'll run RocksDB's dev release, if it is available.

The detection of the debug flag is done in bash since we need to configure the classpath before TypeDB is started. It is complicated if you want do it in TypeDB, after bootup.

However, we may decide that the --debug flag is not critical and/or RocksDB is replaced or never used in dev mode anyway, so we can remove the flag.

@lolski
Copy link
Member Author

lolski commented Jan 15, 2021

[Triaged] @haikalpribadi I am moving it to the backlog since this refactor is not critical

@vmax vmax removed their assignment Jan 20, 2022
@flyingsilverfin flyingsilverfin changed the title Verify if we can move the processing of debug flag to Java from bash for simplicity Remove --debug flag Jan 10, 2023
@flyingsilverfin flyingsilverfin changed the title Remove --debug flag Remove --debug flag to switch classpath Jan 10, 2023
@flyingsilverfin flyingsilverfin self-assigned this Jan 10, 2023
@flyingsilverfin flyingsilverfin changed the title Remove --debug flag to switch classpath Remove TypeDB runner --debug switch Jan 10, 2023
@flyingsilverfin
Copy link
Member

After further discussion, we have agreed that we should keep the --debug flag.

In the ideal scenario, the --debug flag will switch on the dev JAR that contains debugging symbols of the storage library (eg. RocksDB). If we stick with just that behaviour, we should rename it to --devDependencies or --devStorage, etc.

Otherwise, --debug could also take a level --debug=2 which will automatically enable some level of verbose logging throughout the codebase.

@flyingsilverfin flyingsilverfin removed their assignment Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants