Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Almost the last part of a modern WordPress development #149

Closed
matzeeable opened this issue Apr 8, 2020 · 2 comments
Closed

Almost the last part of a modern WordPress development #149

matzeeable opened this issue Apr 8, 2020 · 2 comments
Labels

Comments

@matzeeable
Copy link

Hi!

Here is Matthew from Germany. Believe me, in many years I have gained a lot of experience regarding modern development in the ecosystem of WordPress. It is always difficult for developers to maintain multiple plugins. I have an Open-Source solution for all developers out there: WP React Starter. WP React Starter is built on top of all modern web development tools ported to the WordPress economy.

Why do I open this issue?

I just ran into the problem that there can be different dependency versions between plugins (in relation to Composer). I have found your solution and think:

Lets marriage imposter with wp-react-starter

Are you open to work together to make this work? Due to the fact that WP React Starter is working a lot with traits I need to get this work before I implement it into my open source project. Reference: #111

Please let me know what you think!

@tangrufus
Copy link
Member

wp-react-starter looks awesome.

I presume you want to add imposter to the plugins (https://devowlio.gitbook.io/wp-react-starter/advanced/create-package). Am I correct?

Considerations:

  • Adding imposter introduces complexity
  • If you control all the plugins, making all plugins use the same package version is a better choice (i.e: let the root composer.json determine which version to install)
  • Imposter is far from perfect, we might need to invesgate a real PHP praser, see: [Maybe] Do not use the ugly regex, i.e: abandon this package #101

Anyways, let a comment here if you encounter difficulties integrating imposter with wp-react-starter

@matzeeable
Copy link
Author

Hi again!

Thanks for your words. The last few days I intensively worked on scoping WordPress plugins and found an ultimative way of doing this. I introduced PHP-Scoper to my boilerplate as imposter did not work for me (one reason was #151).

If you or someone else is interested, the boilerplate documentation can be found here.

@tangrufus Behind the scenes, the most important part of scoping are stubs: https://devowlio.gitbook.io/wp-react-starter/php-development/add-classes-hooks-libraries#stubs

Regards,
Matthew 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants